Skip to content

Fixed coding style problem 33 fixes: #2786 #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed coding style problem 33 fixes: #2786 #2849

wants to merge 2 commits into from

Conversation

bobluppes
Copy link

@bobluppes bobluppes commented Oct 5, 2020 •
edited
Loading

Describe your change:

Changed the function name to solution for project euler problem 33.

  • Add an algorithm?
  • [ x ] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ x ] I have read CONTRIBUTING.md.
  • [ x ] This pull request is all my own work -- I have not plagiarized.
  • [ x ] I know that pull requests will not be merged if they fail the automated tests.
  • [ x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x ] All new Python files are placed inside an existing directory.
  • [ x ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ x ] All functions and variable names follow Python naming conventions.
  • [ x ] All function parameters and return values are annotated with Python type hints.
  • [ x ] All functions have doctests that pass the automated testing.
  • [ x ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ x ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

dhruvmanila
dhruvmanila requested changes Oct 6, 2020
View reviewed changes
project_euler/problem_33/sol1.py Outdated
@@ -23,17 +23,17 @@ def isDigitCancelling(num, den):
return True


def solve(digit_len: int) -> str:
def solution(digit_len: int) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the default value for the parameter digit_len such that when called without any arguments solution() returns the right answer to the solution.

@dhruvmanila dhruvmanila added the awaiting changes A maintainer has requested changes to this PR label Oct 6, 2020
@bobluppes
Copy link
Author

Hey @dhruvmanila, sorry, just saw this today. I have updated the code accordingly

@bobluppes bobluppes requested a review from dhruvmanila October 10, 2020 13:18
@dhruvmanila
Copy link
Member

I'm closing this PR as this issue has been fixed.
Refer: #2786

@dhruvmanila dhruvmanila removed the awaiting changes A maintainer has requested changes to this PR label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobluppes @dhruvmanila